🌱 Bump golangci-lint to v1.55.2 #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2511 +/- ##
==========================================
- Coverage 63.91% 63.68% -0.23%
==========================================
Files 123 123
Lines 8790 8790
==========================================
- Hits 5618 5598 -20
- Misses 2751 2767 +16
- Partials 421 425 +4 ☔ View full report in Codecov by Sentry. |
Madhur97
changed the title
|
/retest |
Madhur97
force-pushed
the
golangci-lint
branch
from
9260035
to
7e4ae64
Compare
Madhur97
changed the title
|
Meanwhile golangci-lint v.1.55.2 was released. Would it make sense to upgrade to that? |
Madhur97
force-pushed
the
golangci-lint
branch
from
7e4ae64
to
c7d0a33
Compare
Madhur97
changed the title
chrischdi
reviewed
Nov 20, 2023
k8s-ci-robot
added
the
needs-rebase
sbueringer
force-pushed
the
golangci-lint
branch
from
c7d0a33
to
ff718da
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@adityabhatia @chrischdi Should be ready now |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d6e69a3c63f9c79bbe9347a871d1c48177ff6e7b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bumps the golangci-lint from v1.54.1 to v1.55.1
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2454